httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <>
Subject Re: [PATCH] ap_pcfg_openfile knows about device files
Date Fri, 08 May 1998 18:53:00 GMT

On Fri, 8 May 1998, Jim Jagielski wrote:

> This patch removes the unvoted_DISALLOW_DEVICE_ACCESS wrapper so
> now ap_pcfg_openfile can stop opening of non-/dev/null devices.
> Also, as per Dean's suggestion, it now uses ap_pfopen instead of
> fopen. However, this required some API changes... PLEASE review
> and comment.

Hmm I was trying to remember why I said that :)  Now I remember --

Technically speaking you don't need an API change.  You can create a
structure with the pool and FILE * in it and pass that as the void*.

BTW, in the NSPR version you'll see I switched it to use a BUFF instead. 
Which wouldn't require an API change -- because there's an ap_bclose(). 
And I just realised that in NSPR I should get rid of most of configfile_t
-- keep only the BUFF because you can layer in below the BUFF :)  (it's
cleaner and faster -- faster is an issue for .htaccess files). 


View raw message