httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gregory A Lundberg <lundb...@vr.net>
Subject Re: general/2270: Required Patches to Apache sources for FrontPage Module (fwd)
Date Sun, 24 May 1998 00:07:59 GMT
On Sat, 23 May 1998, Marc Slemko wrote:

> Oh, and on top of that their changes aren't (AFAIK) under a license that
> can be used in Apache.

No, they aren't.

> > Erm... we really don't want to be supporting this lame hack do we?
> > 
> > It is too bad that Microsoft (well, RTR probably...) isn't smart enough to
> > make something work without having to hack Apache, but... 

Only takes a couple hours to fix their module instead of hacking Apache.

> > --- httpd.h	1998/05/22 00:37:29	1.214
> > +++ httpd.h	1998/05/23 19:38:18
> > @@ -689,7 +689,12 @@
> >  
> >      char *unparsed_uri;		/* the uri without any parsing performed */
> >      char *uri;			/* the path portion of the URI */
> > -    char *filename;
> > +    char *execfilename;		/* physical filename to exec */
> > +    char *filename;		/* logical filename to exec -- always the same
> > +				 * except for FrontPage CGI programs where we
> > +				 * will execute the CGI program in
> > +				 * /usr/local/frontpage....
> > +				 */

this is dumb.  it's plain not needed.  they just don't want to learn how
to use Apache.

> > -	if (isspace((*line)[x])) {
> > +	if (isspace((*line)[x]) && ((*line)[x] & 0x80)==0) {

This is dumber.  It and three or four other diff's in the patch they
release appear more to be 'cause that's the way RtR builds Apache for
their site than needed for anyone else.  I guess, if you're compiling
Apache using MS's stuff for Windows you _might_ want something like this
but is it really necessary?  I think not.

I spent a few hours rewriting RtR's Frontpage module to work with Apache
and was able to do away with all this stuff, fix their lame security
setup, and add logging so I can tell what users are doing.  When I was
done it looked like a totally different module but, since it's based on
their lame code, I won't distribute my version.  'sides, while I was
working on it I kept thinking 'standard modules should be able to do most
of this'.

I'd say suspend the request until RtR comes up with something more
reasonable.  Until then let them release a patch and let those who want to
use it without thinking do so (and caveat emptor to them).  But let those
of us who take the time to fix RtRs Frontpage module have an Apache we
won't need to back this junk out of.

----

Gregory A Lundberg		Senior Partner, VRnet Company
1441 Elmdale Drive              lundberg@vr.net
Kettering, OH 45409-1615 USA    1-800-809-2195


Mime
View raw message