httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <ma...@worldgate.com>
Subject Re: [PATCH] Make ErrorDocuments work for Proxy Errors
Date Mon, 25 May 1998 16:51:31 GMT
Actually, I started on something like this a while ago but, like
everything in my poor life, never got around to finishing.

Do this, then make it available to CGIs in the environment (for
ErrorDocument CGIs) and have an option to display it in the error message
generated.

On Mon, 25 May 1998, Martin Kraemer wrote:

> On Sun, May 24, 1998 at 05:33:33PM -0700, Dean Gaudet wrote:
> > Looks fine... although I don't like the addition of yet-another hook for
> > the proxy in the core.  Whoever works on the API for 2.0 should be
> > intimate with how the proxy works so they can plan for it in the API.
> > 
> > Dean
> 
> > >     The patch allows mod_proxy to return the error reason to the
> > >     ap_send_error_response() by using an r->notes string called
> > >     "proxy-error". This string is passed to CGI scripts / ErrorDocuments
> > >     in a newly created "extra" environment variable "REDIRECT_PROXY_ERROR".
> 
> So how about a "more general" solution by renaming "proxy-error" and
> $REDIRECT_PROXY_ERROR to "module-notes" and $MODULE_NOTES? And maybe adding
> them -if set- to every error message, not just 500?
> 
> After all, other modules have a need to add failure reasons to the canned
> replies as well.
> 
> Howzzat?
> 
>     Martin
> -- 
> | S I E M E N S |  <Martin.Kraemer@mch.sni.de>  |      Siemens Nixdorf
> | ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
> | N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
> ~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
> 


Mime
View raw message