httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: Code slush..?
Date Wed, 27 May 1998 20:02:31 GMT
Ralf S. Engelschall wrote:
> 
> In article <3.0.3.32.19980526163855.007dc500@hyperreal.org> you wrote:
> 
> > There is some API cleanup (ralf & dean noticed a few functions without ap_,
> > I want to clean up spawn_child once Ralf commits his changes to
> > mod_rewrite), and the CGI chdir() needs to be done.  Someone really needs
> > to look at the access control problem on Win95, it is a real problem.
> 
> They ap_ patch is comitted now. The patch for making the spawning in
> mod_rewrite correct for Win32 I cannot commit until someone of the Win32-aware
> guys has tested it. I've created it blindly. Ben? Could you test it or at
> least give a statement if its correct this way? I append the patch below
> again.

Certainly it looks OK - I haven't tested it yet, though. Shouldn't you
be using SHELL_PATH instead of "CMD.EXE", though?

OTOH, I'd really rather fix this by adding something to do the
CreateProcess for you.

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|  Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |
A.L. Digital Ltd,     |Apache-SSL author    http://www.apache-ssl.org/
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Mime
View raw message