httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: const stuff (was Re: cvs commit: apache-1.3/src/modules/standard mod_log_referer.c)
Date Mon, 25 May 1998 13:56:03 GMT
Dean Gaudet wrote:
> 
> Yeah I kind of figured this out later while I was thinking about it
> offline.  Everyone else pointed out stuff that I would have -- Marc
> mentioned the main problem, that you're modifying the referer result for
> other callers.
> 
> Ben L. provided a const patch... I actually did this earlier this year,
> but threw it away after I got about an hour into the work.  I figured you
> all would complain to high-heaven if I made such a huge change.

I wouldn't have complained! In fact, I'd still like to put it into 1.3.

>  My goal
> was to make apache compile with gcc -Wwrite-strings cleanly.  Another
> reason for dropping it was the reason Ben H. cited -- that it's hard to
> nail it on all platforms.

Like I said before, I'd rather fix the platforms, one way or another,
than give up on correct constness.

>  .... but I could give it a try with apache-nspr
> if folks are into this huge of a change.

Sure.

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|  Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |
A.L. Digital Ltd,     |Apache-SSL author    http://www.apache-ssl.org/
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Mime
View raw message