httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: cvs commit: apache-1.3/src/modules/standard mod_log_referer.c
Date Thu, 21 May 1998 12:32:42 GMT
Ben Laurie wrote:
> And fixing that produces this alarmingly large patch, that surprisingly
> reveals no other bugs, but may prevent them in future.

Tell a lie - there was a bug in mod_proxy, which modified something
returned by table_get...

> ===================================================================
> RCS file: /export/home/cvs/apache-1.3/src/modules/proxy/proxy_util.c,v
> retrieving revision 1.60
> diff -r1.60 proxy_util.c
> 307,308c307,308
> < char *
> <      ap_proxy_date_canon(pool *p, char *x)
> ---
> > const char *
> >      ap_proxy_date_canon(pool *p, const char *x)
> 356,358c356,357
> <     if (strlen(x)+1 < 30)
> <       x = ap_palloc(p, 30);
> <     ap_snprintf(x, 30, "%s, %.2d %s %d %.2d:%.2d:%.2d GMT", ap_day_snames[wk], mday,
> ---
> >     q = ap_palloc(p, 30);
> >     ap_snprintf(q, 30, "%s, %.2d %s %d %.2d:%.2d:%.2d GMT", ap_day_snames[wk], mday,
> 360c359
> <     return x;
> ---
> >     return q;

Sorry 'bout the diff format, BTW - dunno what came over me!

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|  Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |
A.L. Digital Ltd,     |Apache-SSL author    http://www.apache-ssl.org/
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Mime
View raw message