httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: mod_alias.c, translate_alias_redir
Date Sun, 03 May 1998 10:13:40 GMT
Dean Gaudet wrote:
> 
> translate_alias_redir starts like this:
> 
> #if defined(__EMX__) || defined(WIN32)
>     /* Add support for OS/2 drive names */
>     if ((r->uri[0] != '/' && r->uri[0] != '\0') && r->uri[1]
!= ':')
> #else
>     if (r->uri[0] != '/' && r->uri[0] != '\0')
> #endif
>         return DECLINED;
> 
> This looks like one of those cases that should be using
> ap_os_is_path_absolute().  But in fact I think it's just overzealous
> porting by the win32/emx folks.  r->uri is a uri, not a filesystem path.
> so I think it should just be changed to:
> 
>     if (r->uri[0] != '/' && r->uri[0] != '\0')
>         return DECLINED;

+1

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|  Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |
A.L. Digital Ltd,     |Apache-SSL author    http://www.apache-ssl.org/
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Mime
View raw message