httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Behlendorf <br...@hyperreal.org>
Subject Re: PR #2099
Date Wed, 20 May 1998 23:20:05 GMT

Seems to me it's more efficient to just never make the comparison, and I
think this maps to the semantics better ("we don't care about exiting when
we hit a high number of requests on Win32" versus "you must have zero MRPC
on Win32").  I guess we don't need to increment the requests_this_child
counter either?

A sanity check +1 from a win32 person would be nice.

At 08:08 AM 5/20/98 -0400, Jim Jagielski wrote:
>Shame we can't just force ap_max_requests_per_child to be 0 on Win32...
>Maybe we could disable setting it to anything else under Win32 (the
>default is 0, right)?
>
>Brian Behlendorf wrote:
>> 
>> 
>> How about this patch (to get Win32 to not commit suicide when
>> it hits the MaxRequestsPerChild number)?
>> 
>> http://bugs.apache.org/index/full/2099
>> 
>> Index: http_main.c
>> ===================================================================
>> RCS file: /export/home/cvs/apache-1.3/src/main/http_main.c,v
>> retrieving revision 1.353
>> diff -u -r1.353 http_main.c
>> --- http_main.c	1998/05/14 21:58:26	1.353
>> +++ http_main.c	1998/05/20 12:00:16
>> @@ -3393,10 +3393,14 @@
>>  	    clean_child_exit(0);
>>  	}
>>  
>> +#ifndef WIN32
>>  	if ((ap_max_requests_per_child > 0
>>  	     && ++requests_this_child >= ap_max_requests_per_child)) {
>>  	    clean_child_exit(0);
>>  	}
>> +#else
>> +	++requests_this_child;
>> +#endif
>>  
>>  	(void) ap_update_child_status(my_child_num, SERVER_READY, (request_rec
*) NULL);
>>  
>> 
>> 
>
>
>-- 
>===========================================================================
>   Jim Jagielski   |||   jim@jaguNET.com   |||   http://www.jaguNET.com/
>            "That's no ordinary rabbit... that's the most foul,
>            cruel and bad-tempered rodent you ever laid eyes on"
>
>
--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
pure chewing satisfaction                                  brian@apache.org
                                                        brian@hyperreal.org

Mime
View raw message