httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Behlendorf <br...@hyperreal.org>
Subject Re: Adding the OS type
Date Thu, 07 May 1998 01:57:30 GMT
At 08:24 AM 5/6/98 -0400, Ken wrote:
>Tested.. votes?  Possible for 1.3, Brian?  MMN will need to be bumped
>if/when committed..

Few more comments:

1) The patch file that was posted here needed to be hand-edited; I think
your mailer was word-wrapping some lines.  Mine does too :)  For something
like this I'd post a URL, it's easier for me to handle it that way anyways.

2) I saw changes that had nothing to do with the issue at hand, like some
>80 character lines being split and some indentation fixes.  Since those
were the ones causing me patch grief, I'm a little sore right now about
including unrelated changes into feature patches. 

3) add_component should be add_version_component to make it less ambiguous,
maybe the same with add_platform.

Though this is a feature, we have discussed this off and on for the last 6
months, and I don't feel its added complexity threatens the stability or
performance of the code, so I'm OK with this being in 1.3.0, if it's
sufficiently reviewed.

	Brian


--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
pure chewing satisfaction                                  brian@apache.org
                                                        brian@hyperreal.org

Mime
View raw message