httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: [PATCH] Server: header and tokens
Date Mon, 11 May 1998 12:03:08 GMT
Martin Kraemer wrote:
> 
> Citing Brian:
> > I am okay if "normal" becomes "minimal", and "full" becomes the default.
> 
> I'd prefer "minimal" or over "orig", too. What's so "original" about it?
> I mean, after 1.3 is out, nobody will remember what the "original" was.
> (Or is it supposed to be compatible with the "original" 1.2?)

Minimal it is :)

> 
> > +enum server_token_type {
> > +    ORIG,	/* eg: Apache/1.3.0 */
> > +    OS,      /* eg: Apache/1.3.0 (UNIX) */
> > +    FULL	/* eg: Apache/1.3.0 (UNIX) PHP/3.0 FooBar/1.2b */
> > +};
> 
> Can you please add a prefix token to the constants? In C,
> enumeration tags have global visibility, so they clutter the global
> namespace. Like, e.g.,
> > +enum server_token_type {
> > +    SrvTok_ORIG,    /* eg: Apache/1.3.0 */
> > +    SrvTok_OS,      /* eg: Apache/1.3.0 (UNIX) */
> > +    SrvTok_FULL     /* eg: Apache/1.3.0 (UNIX) PHP/3.0 FooBar/1.2b */
> > +};
> or some such. Feel free to use any sensible prefix.

Good idea.

> 
> That means that "httpd -V" won't ever print the individual modules'
> version strings? Even "httpd -C 'ServerTokens full' -V" or whatever
> could not force them to be printed? Not even the OS part?
> Hmm... I would like it if it was possible to make the OS part and
> module versions display...
> 
> The rest (and the concept) looks good to me.
> 

It's easy to have the OS added, but having the modules add their
tokens requires that the modules actually do their init sequence,
which they don't get to with -V :(

-- 
===========================================================================
   Jim Jagielski   |||   jim@jaguNET.com   |||   http://www.jaguNET.com/
            "That's no ordinary rabbit... that's the most foul,
            cruel and bad-tempered rodent you ever laid eyes on"

Mime
View raw message