httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: cvs commit: apache-1.3/src/main http_main.c
Date Sat, 09 May 1998 00:11:16 GMT
coar@hyperreal.org wrote:
> 
>   	- Make sure that the "(platform)" comment (if enabled) appears at
>   	  a known location in the server version (right after the base
>   	  version string).
>   
>   Revision  Changes    Path
>   1.339     +7 -4      apache-1.3/src/main/http_main.c
>   
>    {
>   +#ifdef SERVER_SUBVERSION
>   +    ap_add_version_component(SERVER_SUBVERSION);
>   +#endif
>        if (ap_note_platform) {
>   -        ap_add_version_component(SERVER_VERSION " (" PLATFORM ")");
>   +        ap_add_version_component(SERVER_BASEVERSION " (" PLATFORM ")");
>        }
>        else {
>   -        ap_add_version_component(SERVER_VERSION);
>   +        ap_add_version_component(SERVER_BASEVERSION);
>        }
>        version_locked++;
>    }
>   

Doesn't this make the results something like:

   (1)  SERVER_SUBVERSION SERVER_BASEVERSION (PLATFORM) ??

I thought we wanted

   (2)  SERVER_BASEVERSION SERVER_SUBVERSION (PLATFORM)

or maybe

   (3)  SERVER_BASEVERSION (PLATFORM) SERVER_SUBVERSION

If (2) then that's what we "already" do, and if (3) then the 
ap_add_version_component(SERVER_SUBVERSION) should be right before
the version_locked++;

-- 
===========================================================================
   Jim Jagielski   |||   jim@jaguNET.com   |||   http://www.jaguNET.com/
            "That's no ordinary rabbit... that's the most foul,
            cruel and bad-tempered rodent you ever laid eyes on"

Mime
View raw message