Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 24567 invoked by uid 6000); 7 Apr 1998 21:38:31 -0000 Received: (qmail 24560 invoked from network); 7 Apr 1998 21:38:30 -0000 Received: from valis.worldgate.com (marcs@198.161.84.2) by taz.hyperreal.org with SMTP; 7 Apr 1998 21:38:30 -0000 Received: from localhost (marcs@localhost) by valis.worldgate.com (8.8.7/8.8.7) with SMTP id PAA00832 for ; Tue, 7 Apr 1998 15:38:28 -0600 (MDT) Date: Tue, 7 Apr 1998 15:38:28 -0600 (MDT) From: Marc Slemko To: new-httpd@apache.org Subject: Re: [PATCH] inaddr printf stuff In-Reply-To: <19980407220556.25965@deejai.mch.sni.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org On Tue, 7 Apr 1998, Martin Kraemer wrote: > On Tue, Apr 07, 1998 at 03:51:02AM -0700, Dean Gaudet wrote: > > But the disadvantage is that it still requires a lot > > of code to be fixed, and folks will still forget this stuff in their error > > messages. > > If they forget to fix it, then aplog_rerror() won't help either. If I have to add a error message, and I have a choice between formatting the whole message myself, keeping a consistent format, etc. and just including the minimal information, I will include the minimal information. If I have a choice between using a function that includes extra information automatically and using one that doesn't, I will probably use one that includes extra information. Consistent log messages are good. Not having a zillion different formats for the same thing is good. "template" functions for logging specific types of messages are good, they just can't go overboard.