httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] inaddr printf stuff
Date Tue, 07 Apr 1998 22:09:50 GMT
Right, both are fine... well, %pA otherwise we have to disable gcc's
printf warnings and I don't want to do that.

Dean

On Tue, 7 Apr 1998, Martin Kraemer wrote:

> On Tue, Apr 07, 1998 at 02:27:06PM -0700, Dean Gaudet wrote:
> > Take a peek at 1.2 code, look for all instances of log_reason()... every
> > one of those includes the client hostname.  Those have all been converted
> > to aplog_error() in 1.3 and no longer include the client hostname.  This
> > is a big problem in my opinion, the messages are mostly useless now. 
> 
> Don't you think that the existance of a %A format would have helped?
> Okay, I see, the request_rec is a prerequisite for the formatter to
> know about the address. But can't we have both: an aplog_rerror() taking
> the request_rec _and_ the %A format to go with it which prints the
> address at the place where it's useful, and not always at the beginning?
> 
>     Martin
> -- 
> | S I E M E N S |  <Martin.Kraemer@mch.sni.de>  |      Siemens Nixdorf
> | ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
> | N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
> ~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
> 


Mime
View raw message