httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexei Kosut <ako...@leland.Stanford.EDU>
Subject Re: C++ and pool (again) in 1.3b6
Date Fri, 24 Apr 1998 23:39:28 GMT
On Fri, 24 Apr 1998, Dean Gaudet wrote:

> Submitting a patch here, with [PATCH] in the subject line is the best way. 
> I'm not sure what name to use, pool_ptr is what you suggested before?  If
> so that sounds fine. 

Hmm. IMHO, to maintain backwards compatibility, wouldn't it be better
to change "pool" than "pool"? Er... I mean, change the type name instead
of the structure member name?

If we change "pool *pool" to "pool *pool_ptr" then all modules that access
that pool will need to be changed. If we change "pool *pool" to "ap_pool
*pool" then any module that references "r->pool" will still work just
fine, and we can throw in a "typedef pool ap_pool" in #ifndef __cplusplus
wrappers so that all existing source will continue to work. It also fits
in with that renaming thing we did a few weeks back; "pool" has got to be
a common enough name that people have run into problems, right?

Then again, "array" and "table" sound common too, but I don't recall any
issues there.

-- Alexei Kosut <> <>
   Stanford University, Class of 2001 * Apache <> *

View raw message