httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: cvs commit: apache-1.3/src/include compat.h
Date Mon, 13 Apr 1998 16:44:46 GMT
Ralf S. Engelschall wrote:
> 
> In article <199804131541.LAA21913@devsys.jaguNET.com> you wrote:
> > Ben Laurie wrote:
> >>
> >> rse@hyperreal.org wrote:
> >> >   - renamed remaining os_ stuff in os/unix/ and os/bs2000/ to ap_ variants
> >>
> >> I don't remember buying into removal of os_ as part of adding ap_.
> >> Surely the correct thing to do is call it ap_os_ (or apos_, but I
> >> suppose that would be against the rules)? I think it is a definite
> >> backwards step to lose sight of which functions actually change on a
> >> per-OS basis.
> >>
> 
> > Especially when they are already protected from name-space collisons,
> > supposedly the whole and entire reason for this.
> 
> Ok, now that we have a flexible renaming tool, this issue
> is just a problem of 5 minutes. I've run the rename stuff
> with this little config:
> 
> ap_dso_error                        ap_os_dso_error
> ap_dso_sym                          ap_os_dso_sym
> ap_dso_unload                       ap_os_dso_unload
> ap_dso_load                         ap_os_dso_load
> ap_canonical_filename               ap_os_canonical_filename
> ap_is_path_absolute                 ap_os_is_path_absolute
> ap_escape_path                      ap_os_escape_path
> 
> How about the resulting patch I appended?

+1.

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|  Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |
A.L. Digital Ltd,     |Apache-SSL author    http://www.apache-ssl.org/
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Mime
View raw message