httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: SHARED_MODULE/IS_MODULE
Date Mon, 06 Apr 1998 20:52:55 GMT
Alexei Kosut wrote:
> 
> A few weeks ago, I noted that the Win32 define IS_MODULE really means
> the same thing as our Unix define SHARED_MODULE, and I suggested renaming
> the former. I've also realized that defining IS_MODULE in the module file
> (e.g. mod_status.c) is rather a silly idea, because if someone decided to
> include mod_status.c in the Win32 core instead of loading it in as a DLL,
> things would go haywire.
> 
> In short; I'd like to change all instances of IS_MODULE to SHARED_MODULE,

+1

> and move the defines out of the source files and into the .dsp/.mak files
> in src/os/win32.

Not so sure about this part - but I suppose it is the only way. The only
thing I dislike about it is that it makes it hard to know that
SHARED_MODULE has been defined.

I suppose a big comment somewhere explaining would help.

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|  Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |
A.L. Digital Ltd,     |Apache-SSL author    http://www.apache-ssl.org/
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Mime
View raw message