httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <Martin.Krae...@mch.sni.de>
Subject Re: [PATCH] inaddr printf stuff
Date Tue, 07 Apr 1998 20:05:56 GMT
On Tue, Apr 07, 1998 at 03:51:02AM -0700, Dean Gaudet wrote:
> But the disadvantage is that it still requires a lot
> of code to be fixed, and folks will still forget this stuff in their error
> messages.

If they forget to fix it, then aplog_rerror() won't help either.

> So in addition I'd like to propose:
> 
> API_EXPORT(void) aplog_rerror(const char *file, int line, int level,
>                              const request_rec *s, const char *fmt, ...)
>                             __attribute__((format(printf,5,6)));
> 
> Which takes a request_rec instead of a server_rec, and prints the relevant
> client fields at the beginning of the message.

What do you mean by "the relevant client fields"? Does
aplog_rerror() insert info from the request_req without asking? Or
is it simply a wrapper to aplog_error(...., r->server,...)? In the
first case, IMO the number of cases where exactly "the relevant
client fields" should be printed are limited. I opt for the more
flexible solution where everything you want to be printed must be
specified in the format.

    Martin
--
| S I E M E N S |  <Martin.Kraemer@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

Mime
View raw message