httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@engelschall.com (Ralf S. Engelschall)
Subject Re: pstrcat?
Date Sat, 04 Apr 1998 13:06:52 GMT

In article <Pine.LNX.3.96dg4.980402110508.8503C-100000@twinlark.arctic.org> you wrote:

> pstrcat and null_cleanup are among the API_EXPORT_NONSTD symbols, and all
> of those are part of the API.  The _NONSTD part is an indication that they
> have different calling conventions on WIN32, not that they are
> "non-standard" or anything like that.  The name is a bit misleading.

> pstrdup is definately part of the API as well.

Ok, but then we should fix the inconsistency by the following path, correct?

Index: main/alloc.c
===================================================================
RCS file: /e/apache/REPOS/apache-1.3/src/main/alloc.c,v
retrieving revision 1.84
diff -u -r1.84 alloc.c
--- alloc.c	1998/03/31 12:52:39	1.84
+++ alloc.c	1998/04/04 13:04:55
@@ -737,7 +737,7 @@
     return res;
 }
 
-char *pstrcat(pool *a,...)
+API_EXPORT_NONSTD(char *) pstrcat(pool *a,...)
 {
     char *cp, *argp, *res;
 
Index: include/alloc.h
===================================================================
RCS file: /e/apache/REPOS/apache-1.3/src/include/alloc.h,v
retrieving revision 1.52
diff -u -r1.52 alloc.h
--- alloc.h	1998/03/31 12:52:16	1.52
+++ alloc.h	1998/04/04 13:05:42
@@ -122,7 +122,7 @@
 API_EXPORT(char *) pstrdup(struct pool *, const char *s);
 /* make a nul terminated copy of the n characters starting with s */
 API_EXPORT(char *) pstrndup(struct pool *, const char *s, int n);
-API_EXPORT(char *) pstrcat(struct pool *,...);	/* all '...' must be char* */
+API_EXPORT_NONSTD(char *) pstrcat(struct pool *,...);	/* all '...' must be char* */
 API_EXPORT_NONSTD(char *) psprintf(struct pool *, const char *fmt, ...)
     __attribute__((format(printf,2,3)));
 API_EXPORT(char *) pvsprintf(struct pool *, const char *fmt, va_list);

                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message