httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: BrowserMatch considered harmful
Date Thu, 12 Mar 1998 21:04:05 GMT
Yeah that is ugly... but I'm not seeing a huge difference between having
the 5 browsermatches and not having them... I still get around 31% of the
time spent in regexec(), and it's all due to parse_uri_components in that
case.  Do you see the same thing?

Dean

On Thu, 12 Mar 1998, Dmitry Khrustalev wrote:

> 
> 
> On Thu, 12 Mar 1998, Dean Gaudet wrote:
> 
> > I've been meaning to do this -- I'm not sure if it's the browser-match
> > rules or if it's because of the util_uri regex parser in your case.  I was
> > going to hand code the util_uri parser after the rest of the code was
> > shown to be right. 
> 
>   Both, but browsermatch is really evil. match_headers takes 38.5 percent.
> considering it's work could be done with simple strstr, it's awful waste.
> also, it will do strcasecmp 5 * ( number of configured rules ) times.
> 
> > 
> > Dean
> > 
> > On Thu, 12 Mar 1998, Dmitry Khrustalev wrote:
> > 
> > > 
> > > I wonder is anyone profiled httpd using distributed configuration?
> > > 
> > > regexec takes 45 percent of CPU time. 5 browser-match rules are
> > > configured, all simple substring matches. 
> > > 
> > > 	-Dima
> > > 
> > > 
> > 
> 
> 


Mime
View raw message