Message-ID: <34E2E985.6F4F26CF@Golux.Com>
Date: Thu, 12 Feb 1998 07:22:29 -0500
From: Rodent of Unusual Size <Ken.Coar@Golux.Com>
Organization: The Apache Group
MIME-Version: 1.0
To: new-httpd@apache.org
Subject: Re: cvs commit: apache-1.3/src/regex Makefile.tmpl
References: <19980212101530.24222.qmail@hyperreal.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

I'm all for correct dependencies, but I *really* dislike
ditching the simplicity of "$(INCDIR)/foo.h" for explicit
relative paths.  I'm also slightly concerned about the
portability of the sed script (but only slightly, since
we're not expecting any non-experts to do this, and if
they do it's on their own heads) - I'm not a sed expert,
but ISTR that we've had some problems in the past.  And
I'm also a little bit concerned about the automatic
makedepend on "*.c".  But those are minor - the
explicit paths thing is more significant.  And if it's
gcc-specific, I'd rather make that obvious than beg the
question and have PRs about why it won't work with other
compilers.

How about changing

depend:
    sed -ne '1,/^# DO NOT REMOVE/p' Makefile.tmpl > Makefile.new \
	&& $(CC) -MM $(INCLUDES) $(CFLAGS) *.c >> Makefile.new \
	&& mv Makefile.tmpl Makefile.tmpl.bak \
	&& mv Makefile.new Makefile.tmpl

to

depend:
    cp Makefile.tmpl Makefile.tmpl.bak \
	&& sed -ne '1,/^# DO NOT REMOVE/p' Makefile.tmpl > Makefile.new \
        && gcc -MM $(INCLUDES) $(CFLAGS) *.c >> Makefile.new \
	&& sed -e '1,s: $(INCDIR)/: \$(INCDIR)/:g' Makefile.new > Makefile.tmpl \
        && rm Makefile.new

(untested)?

#ken	P-)}