Message-ID: <34DA0F11.CAB1F9BF@algroup.co.uk>
Date: Thu, 05 Feb 1998 19:12:17 +0000
From: Ben Laurie <ben@algroup.co.uk>
Organization: A.L. Digital Ltd.
MIME-Version: 1.0
To: new-httpd@apache.org
Subject: Re: directory_walk bug?
References: <Pine.LNX.3.96dg4.980202223335.3588Y-100000@twinlark.arctic.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

Dean Gaudet wrote:
> 
> directory_walk looks like this:
> 
>     test_filename = pstrdup(r->pool, r->filename);
> 
>     if (!os_is_path_absolute(test_filename))
>     {
>         ...
>     }
> 
>     r->filename   = os_canonical_filename(r->pool, r->filename);
>     no2slash(test_filename);
>     num_dirs = count_dirs(test_filename);
> 
>     ...
> 
> I believe that there's a bug.  I think that test_filename is
> probably supposed to be a copy of the r->filename after
> the os_canonical_filename.  test_filename is what's actually
> used to do all the comparisons later on.

Hmmm... if only I could remember which way round it was before we move
the os_canonical_filename. However, I'm inclined to agree.

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author
A.L. Digital Ltd,     |http://www.algroup.co.uk/Apache-SSL
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache