Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 21518 invoked by uid 6000); 3 Feb 1998 20:18:26 -0000 Received: (qmail 21511 invoked from network); 3 Feb 1998 20:18:24 -0000 Received: from thoth.mch.sni.de (192.35.17.2) by taz.hyperreal.org with SMTP; 3 Feb 1998 20:18:24 -0000 Received: from deejai.mch.sni.de (deejai.mch.sni.de [139.25.113.10]) by thoth.mch.sni.de (8.8.8/8.8.8) with ESMTP id VAA25961 for ; Tue, 3 Feb 1998 21:18:23 +0100 (MET) Received: (from martin@localhost) by deejai.mch.sni.de (8.8.7/8.8.7) id VAA07061; Tue, 3 Feb 1998 21:18:20 +0100 (MET) Message-ID: <19980203211817.06723@deejai.mch.sni.de> Date: Tue, 3 Feb 1998 21:18:17 +0100 From: Martin Kraemer To: new-httpd@apache.org Subject: Re: cvs commit: apache-1.3/src/main http_vhost.c References: <19980203171816.29787@deejai.mch.sni.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.69 In-Reply-To: ; from Dean Gaudet on Tue, Feb 03, 1998 at 11:50:37AM -0800 Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org On Tue, Feb 03, 1998 at 11:50:37AM -0800, Dean Gaudet wrote: > But that still doesn't solve the bug Marc brought up. > > http://twinlark./ should fail, it shouldn't match a "ServerAlias twinlark" Oh well, another can of worms. The matching of "config words" to server names, domain substrings, glob patterns and regex patterns is, to say it mildly, catastrophic in apache. You probably hit a "regex"-'.' or anything. There are loads of "strstr" matches in the code, especially in the proxy module. When I added the NoProxy directive, I tried to resolve part of this by defining a precise syntax for - domain names (and how they're matched) - IP Addrs (and how they're matched) - SubnetAdds (and how they're matched) - Host Names (and how they're matched) - all the rest (and how it's matched) These "config word" matches should _ALL_ be precisely defined, and best handled in a set of central routines, for each of the classes of "config words" we want to handle. And there should be a syntax to write "I want this word to be a glob pattern" or "this word is an IP subnet" etc. I hope you understand what I'm so angry about when you have a look at mod_proxy.html: The NoCache directive specifies a list of words, hosts and/or domains, separated by spaces. HTTP and non-passworded FTP documents from matched words, hosts or domains are _not_ cached by the proxy server. The proxy module will also attempt to determine IP addresses of list items which may be hostnames during startup, and cache them for match test as well. How would _you_ program a match for "a list of words, hosts and/or domains"? Martin -- | S I E M E N S | | Siemens Nixdorf | ------------- | Voice: +49-89-636-46021 | Informationssysteme AG | N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany ~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request