httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] fix problem if Port is unset!
Date Sat, 07 Feb 1998 20:31:13 GMT
I think this breaks something else... please hold off, we can just "Known
bug" the UseCanonicalName directive's behaviour w.r.t. Port for 1.3b4. 

Dean

On Sat, 7 Feb 1998, Lars Eilebrecht wrote:

> Hi,
> 
> recent code changes (UseCanonicalName?) broke all configs where
> "Port" is unset.
> I noticed it, because I'm typically using "Listen 80" in my configs
> and leave "Port" undefined, because "Port 80" is the default.
> This results in directory-redirects with a port set to "0".
> 
> The UseCanonicalName code uses "r->server->port", but this is
> set to "0" in http_config.c. Is there are reason for setting
> it to zero? My attached patch uses "default_port(s)" instead
> which seems to work for me.
> 
> This problem should be fixed before 1.3b4 is released...
> 
> 
> ciao...
> -- 
> Lars Eilebrecht                        - "What you see is all you get."
> sfx@unix-ag.org                                       (Brian Kernighan)
> http://www.si.unix-ag.org/~sfx/
> 
> 

Mime
View raw message