httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: "No TransferLog disables logging"
Date Tue, 10 Feb 1998 08:48:34 GMT
Marc Slemko wrote:
> 
> This change was made in 1.3b<mumble> from a patch from uunet or somewhere.
> 
> I'm afraid I don't fully understand the changed behaviour.
> 
> The patch was:
> 
> Index: mod_log_config.c
> ===================================================================
> RCS file: /export/home/cvs/apache-1.3/src/modules/standard/mod_log_config.c,v
> retrieving revision 1.35
> retrieving revision 1.36
> diff -r1.35 -r1.36
> 53a54,56
> >  * Modified by djm@va.pubnix.com:
> >  * If no TransferLog is given explicitly, decline to log.
> >  *
> 534a538,541
> >     if (cls->fname == NULL) {
> >       return DECLINED;
> >     }
> >
> 705a713,716
> >
> >     if (cls->fname == NULL) {
> >         return cls;           /* Leave it NULL to decline.  */
> >     }

What is that comment supposed to mean? I suppose it may make more sense
in context...

> 
> But if I don't specify a TransferLog in 1.2 it doesn't log, and this
> isn't in 1.2.

But does it try to log (and fail, of course)?

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author
A.L. Digital Ltd,     |http://www.algroup.co.uk/Apache-SSL
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Mime
View raw message