httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: [PATCH] fix problem if Port is unset!
Date Sat, 07 Feb 1998 21:25:54 GMT
Dean Gaudet wrote:
> 
> Randy's "generalize default_port manipulations" patch on feb 2nd is the
> cause of this bug.  Randy I can't figure out why your patch does this:
> 
>   Index: http_config.c
>   ===================================================================
>   RCS file: /export/home/cvs/apache-1.3/src/main/http_config.c,v
>   retrieving revision 1.94
>   retrieving revision 1.95
>   diff -u -r1.94 -r1.95
>   --- http_config.c     1998/01/21 22:11:01     1.94
>   +++ http_config.c     1998/02/02 22:33:31     1.95
>   @@ -1225,7 +1225,7 @@
>    {
>        server_rec *s = (server_rec *) pcalloc(p, sizeof(server_rec));
> 
>   -    s->port = DEFAULT_PORT;
>   +    s->port = 0;
>        s->server_admin = DEFAULT_ADMIN;
>        s->server_hostname = NULL;
>        s->error_fname = DEFAULT_ERRORLOG;
> 
> Nothing appears to actually test if s->port == 0.  They all test against
> DEFAULT_PORT.  I'm thinking that the above hunk is an SSLism that should
> be backed out.  I'm guessing the SSL is_default_port() function
> understands a 0 port.

My guess would be that Apache-SSL has inadvertantly preserved this
misfeature from the old Apaches that did it this way. I'd check, but
right now I'm chasing that Win32 CGI thing (and its just hung so now to
try with the patch...).

If anyone else finds it is so, let me know, and I'll fix it for the next
release (which is coming soon).

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author
A.L. Digital Ltd,     |http://www.algroup.co.uk/Apache-SSL
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Mime
View raw message