httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@engelschall.com (Ralf S. Engelschall)
Subject Re: Interesting problem: virtual host config
Date Fri, 27 Feb 1998 20:49:53 GMT

In article <Pine.LNX.3.96dg4.980227121642.286I-100000@twinlark.arctic.org> you wrote:

> I think this breaks various modules... like mod_log_config for example. 
> All the modules which expect inheritance or something like that. 
>[...]
>> I'm not sure if the following change is really a good one, but it would solve
>> the problem, I think and would avoid confusion in the future. On the other
>> hand it forces a little bit too much config-initialisation on startup.  But
>> its on startup so we could accept this. Is this again totally wrong or perhaps
>> a possibility?
>> 
>> Index: http_config.c
>> ===================================================================
>> RCS file: /e/apache/REPOS/apache-1.3/src/main/http_config.c,v
>> retrieving revision 1.99
>> diff -u -r1.99 http_config.c
>> --- http_config.c       1998/02/25 09:36:12     1.99
>> +++ http_config.c       1998/02/27 13:11:32
>> @@ -1177,11 +1177,11 @@
>>      s->is_virtual = 1;
>>      s->names = NULL;
>>  
>> -    s->module_config = create_empty_config(p);
>> -    s->lookup_defaults = create_per_dir_config(p);
>> -
>>      s->server_uid = user_id;
>>      s->server_gid = group_id;
>> +
>> +    s->module_config = create_server_config(p, s);
>> +    s->lookup_defaults = create_per_dir_config(p);
>>  
>>      *ps = s;

Are you sure it'll break it? I'm not sure myself, of course. But I think it
should work, because currently the other modules do their
create_server_config() on-the-fly while with the patch they do it a little but
earlier. But in both ways I think the configure the same. 

                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message