httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject 9 forwarded messages...
Date Tue, 20 Jan 1998 01:46:07 GMT
In under an hour I was able to accomplish way more than I could have had I
posted these things for voting.

Form your own opinions.  Reverse this stuff if you want, I don't give a
crap.  You're only hurting the product. 

Dean

---------- Forwarded message ----------
Date: 20 Jan 1998 00:27:21 -0000
From: dgaudet@hyperreal.org
To: apachen-cvs@hyperreal.org
Subject: cvs commit: apachen/src/modules/standard mod_rewrite.c
Reply-To: new-httpd@apache.org

dgaudet     98/01/19 16:27:21

  Modified:    .        STATUS
               src      CHANGES
               src/modules/standard mod_rewrite.c
  Log:
  RewriteLog shouldn't force hostname lookups.
  
  PR:		1684
  
  Revision  Changes    Path
  1.101     +1 -0      apachen/STATUS
  
  Index: STATUS
  ===================================================================
  RCS file: /export/home/cvs/apachen/STATUS,v
  retrieving revision 1.100
  retrieving revision 1.101
  diff -u -r1.100 -r1.101
  --- STATUS	1998/01/20 00:25:13	1.100
  +++ STATUS	1998/01/20 00:27:07	1.101
  @@ -83,6 +83,7 @@
       * Martin's [PATCH] mod_speling [300] Multiple Choices bug (Take 2)
       * Dean's [PATCH] protect the environment
       * general/1666: Apache uses a case sensitive match for "Basic" auth scheme
  +    * mod_rewrite/1684: RewriteLog directive does the equivalent of "HostnameLookups on"
   
   Available Patches:
   
  
  
  
  1.568     +3 -0      apachen/src/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /export/home/cvs/apachen/src/CHANGES,v
  retrieving revision 1.567
  retrieving revision 1.568
  diff -u -r1.567 -r1.568
  --- CHANGES	1998/01/20 00:07:20	1.567
  +++ CHANGES	1998/01/20 00:27:15	1.568
  @@ -1,5 +1,8 @@
   Changes with Apache 1.3b4
   
  +  *) mod_rewrite's RewriteLog should behave like mod_log_config, it
  +     shouldn't force hostname lookups.  [Dean Gaudet] PR#1684
  +
     *) "basic" auth needs a case-insensitive comparison.
        [Ronald.Tschalaer@psi.ch] PR#1666
   
  
  
  
  1.62      +1 -1      apachen/src/modules/standard/mod_rewrite.c
  
  Index: mod_rewrite.c
  ===================================================================
  RCS file: /export/home/cvs/apachen/src/modules/standard/mod_rewrite.c,v
  retrieving revision 1.61
  retrieving revision 1.62
  diff -u -r1.61 -r1.62
  --- mod_rewrite.c	1998/01/13 23:11:26	1.61
  +++ mod_rewrite.c	1998/01/20 00:27:20	1.62
  @@ -2749,7 +2749,7 @@
           ruser = "\"\"";
       }
   
  -    rhost = get_remote_host(conn, r->server->module_config, REMOTE_NAME);
  +    rhost = get_remote_host(conn, r->server->module_config, REMOTE_NOLOOKUP);
       if (rhost == NULL)
           rhost = "UNKNOWN-HOST";
   
  
  
  



---------- Forwarded message ----------
Date: 20 Jan 1998 00:33:14 -0000
From: dgaudet@hyperreal.org
To: apachen-cvs@hyperreal.org
Subject: cvs commit: apachen/src/main http_protocol.c
Reply-To: new-httpd@apache.org

dgaudet     98/01/19 16:33:14

  Modified:    .        STATUS
               src      CHANGES
               src/main http_protocol.c
  Log:
  The "Connection" header could be sent back with multiple "close"
  tokens.  Not an error, but a waste.
  
  PR:		1683
  Submitted by:	Ronald.Tschalaer@psi.ch
  Reviewed by:	Dean Gaudet
  
  Revision  Changes    Path
  1.102     +1 -0      apachen/STATUS
  
  Index: STATUS
  ===================================================================
  RCS file: /export/home/cvs/apachen/STATUS,v
  retrieving revision 1.101
  retrieving revision 1.102
  diff -u -r1.101 -r1.102
  --- STATUS	1998/01/20 00:27:07	1.101
  +++ STATUS	1998/01/20 00:33:09	1.102
  @@ -84,6 +84,7 @@
       * Dean's [PATCH] protect the environment
       * general/1666: Apache uses a case sensitive match for "Basic" auth scheme
       * mod_rewrite/1684: RewriteLog directive does the equivalent of "HostnameLookups on"
  +    * protocol/1683: The Connection header may contain multiple close tokens
   
   Available Patches:
   
  
  
  
  1.569     +4 -0      apachen/src/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /export/home/cvs/apachen/src/CHANGES,v
  retrieving revision 1.568
  retrieving revision 1.569
  diff -u -r1.568 -r1.569
  --- CHANGES	1998/01/20 00:27:15	1.568
  +++ CHANGES	1998/01/20 00:33:10	1.569
  @@ -1,5 +1,9 @@
   Changes with Apache 1.3b4
   
  +  *) The "Connection" header could be sent back with multiple "close"
  +     tokens.  Not an error, but a waste.
  +     [Ronald.Tschalaer@psi.ch] PR#1683
  +
     *) mod_rewrite's RewriteLog should behave like mod_log_config, it
        shouldn't force hostname lookups.  [Dean Gaudet] PR#1684
   
  
  
  
  1.176     +2 -1      apachen/src/main/http_protocol.c
  
  Index: http_protocol.c
  ===================================================================
  RCS file: /export/home/cvs/apachen/src/main/http_protocol.c,v
  retrieving revision 1.175
  retrieving revision 1.176
  diff -u -r1.175 -r1.176
  --- http_protocol.c	1998/01/20 00:07:22	1.175
  +++ http_protocol.c	1998/01/20 00:33:12	1.176
  @@ -346,7 +346,8 @@
        * as HTTP/1.0, but pass our request along with our HTTP/1.1 tag
        * to a HTTP/1.1 client. Better safe than sorry.
        */
  -    table_merge(r->headers_out, "Connection", "close");
  +    if (!wimpy)
  +      table_merge(r->headers_out, "Connection", "close");
   
       r->connection->keepalive = 0;
   
  
  
  



---------- Forwarded message ----------
Date: 20 Jan 1998 00:35:20 -0000
From: dgaudet@hyperreal.org
To: apache-cvs@hyperreal.org
Subject: cvs commit: apache/src CHANGES http_protocol.c
Reply-To: new-httpd@apache.org

dgaudet     98/01/19 16:35:20

  Modified:    .        Tag: APACHE_1_2_X STATUS
               src      Tag: APACHE_1_2_X CHANGES http_protocol.c
  Log:
  Multiple "close" tokens may have been set in the "Connection"
  header, not an error, but a waste.
  
  PR:		1683
  Submitted by:	Ronald.Tschalaer@psi.ch
  Reviewed by:	Dean Gaudet
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.1.2.16  +1 -0      apache/Attic/STATUS
  
  Index: STATUS
  ===================================================================
  RCS file: /export/home/cvs/apache/Attic/STATUS,v
  retrieving revision 1.1.2.15
  retrieving revision 1.1.2.16
  diff -u -r1.1.2.15 -r1.1.2.16
  --- STATUS	1998/01/20 00:09:22	1.1.2.15
  +++ STATUS	1998/01/20 00:35:15	1.1.2.16
  @@ -13,6 +13,7 @@
       * Ralf's mod_rewrite bugfix for %3f
       * backport of the netscape header padding fix
       * general/1666: basic auth token should be tested case-insensitive
  +    * protocol/1683: The Connection header may contain multiple close tokens
   
   Available:
   
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.286.2.68 +4 -0      apache/src/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /export/home/cvs/apache/src/CHANGES,v
  retrieving revision 1.286.2.67
  retrieving revision 1.286.2.68
  diff -u -r1.286.2.67 -r1.286.2.68
  --- CHANGES	1998/01/20 00:09:23	1.286.2.67
  +++ CHANGES	1998/01/20 00:35:17	1.286.2.68
  @@ -1,5 +1,9 @@
   Changes with Apache 1.2.6
   
  +  *) Multiple "close" tokens may have been set in the "Connection"
  +     header, not an error, but a waste.
  +     [Ronald.Tschalaer@psi.ch] PR#1683
  +
     *) "basic" auth token should be tested case-insensitive.
        [Ronald.Tschalaer@psi.ch] PR#1666
   
  
  
  
  1.126.2.9 +2 -1      apache/src/http_protocol.c
  
  Index: http_protocol.c
  ===================================================================
  RCS file: /export/home/cvs/apache/src/http_protocol.c,v
  retrieving revision 1.126.2.8
  retrieving revision 1.126.2.9
  diff -u -r1.126.2.8 -r1.126.2.9
  --- http_protocol.c	1998/01/20 00:09:25	1.126.2.8
  +++ http_protocol.c	1998/01/20 00:35:18	1.126.2.9
  @@ -339,7 +339,8 @@
        * as HTTP/1.0, but pass our request along with our HTTP/1.1 tag
        * to a HTTP/1.1 client. Better safe than sorry.
        */
  -    table_merge(r->headers_out, "Connection", "close");
  +    if (!wimpy)
  +	table_merge(r->headers_out, "Connection", "close");
   
       r->connection->keepalive = 0;
   
  
  
  



---------- Forwarded message ----------
Date: 20 Jan 1998 00:49:39 -0000
From: dgaudet@hyperreal.org
To: apache-cvs@hyperreal.org
Subject: cvs commit: apache/src/modules/proxy proxy_ftp.c
Reply-To: new-httpd@apache.org

dgaudet     98/01/19 16:49:39

  Modified:    .        Tag: APACHE_1_2_X STATUS
               src      Tag: APACHE_1_2_X CHANGES
               src/modules/proxy Tag: APACHE_1_2_X proxy_ftp.c
  Log:
  mod_proxy was sending HTTP/1.1 responses to ftp requests by mistake.
  Also removed the auto-generated link to www.apache.org that was the
  source of so many misdirected bug reports.  (fixed in 1.3b1)
  
  Submitted by:	Roy Fielding, Marc Slemko
  Reviewed by:	Dean Gaudet
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.1.2.17  +1 -0      apache/Attic/STATUS
  
  Index: STATUS
  ===================================================================
  RCS file: /export/home/cvs/apache/Attic/STATUS,v
  retrieving revision 1.1.2.16
  retrieving revision 1.1.2.17
  diff -u -r1.1.2.16 -r1.1.2.17
  --- STATUS	1998/01/20 00:35:15	1.1.2.16
  +++ STATUS	1998/01/20 00:49:34	1.1.2.17
  @@ -14,6 +14,7 @@
       * backport of the netscape header padding fix
       * general/1666: basic auth token should be tested case-insensitive
       * protocol/1683: The Connection header may contain multiple close tokens
  +    * proxy was sending HTTP/1.1 responses in error
   
   Available:
   
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.286.2.69 +4 -0      apache/src/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /export/home/cvs/apache/src/CHANGES,v
  retrieving revision 1.286.2.68
  retrieving revision 1.286.2.69
  diff -u -r1.286.2.68 -r1.286.2.69
  --- CHANGES	1998/01/20 00:35:17	1.286.2.68
  +++ CHANGES	1998/01/20 00:49:36	1.286.2.69
  @@ -1,5 +1,9 @@
   Changes with Apache 1.2.6
   
  +  *) mod_proxy was sending HTTP/1.1 responses to ftp requests by mistake.
  +     Also removed the auto-generated link to www.apache.org that was the
  +     source of so many misdirected bug reports.  [Roy Fielding, Marc Slemko]
  +
     *) Multiple "close" tokens may have been set in the "Connection"
        header, not an error, but a waste.
        [Ronald.Tschalaer@psi.ch] PR#1683
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.21.2.3  +6 -5      apache/src/modules/proxy/proxy_ftp.c
  
  Index: proxy_ftp.c
  ===================================================================
  RCS file: /export/home/cvs/apache/src/modules/proxy/proxy_ftp.c,v
  retrieving revision 1.21.2.2
  retrieving revision 1.21.2.3
  diff -u -r1.21.2.2 -r1.21.2.3
  --- proxy_ftp.c	1998/01/05 21:05:07	1.21.2.2
  +++ proxy_ftp.c	1998/01/20 00:49:38	1.21.2.3
  @@ -372,9 +372,10 @@
               o+=w;
           }
       }
  -    ap_snprintf(buf, sizeof(buf), "</PRE><HR><I><A HREF=\"http://www.apache.org\">%s</A></I></BODY></HTML>",
SERVER_VERSION);
  -    bwrite(con->client, buf, strlen(buf));
  -    if (f2 != NULL) bwrite(f2, buf, strlen(buf));
  +    bputs("</PRE><HR></BODY></HTML>\015\012", con->client);
  +    if (f2 != NULL) {
  +	bputs("</PRE><HR></BODY></HTML>\015\012", f2);
  +    }
       total_bytes_sent+=strlen(buf);
       bflush(con->client);
       
  @@ -944,9 +945,9 @@
   /* send response */
   /* write status line */
       if (!r->assbackwards)
  -	rvputs(r, SERVER_PROTOCOL, " ", r->status_line, "\015\012", NULL);
  +	rvputs(r, "HTTP/1.0 ", r->status_line, "\015\012", NULL);
       if (cache != NULL)
  -	if (bvputs(cache, SERVER_PROTOCOL, " ", r->status_line, "\015\012",
  +	if (bvputs(cache, "HTTP/1.0 ", r->status_line, "\015\012",
   		   NULL) == -1)
   	    cache = proxy_cache_error(c);
   
  
  
  



---------- Forwarded message ----------
Date: 20 Jan 1998 00:52:17 -0000
From: dgaudet@hyperreal.org
To: apache-cvs@hyperreal.org
Subject: cvs commit: apache/src CHANGES http_protocol.c
Reply-To: new-httpd@apache.org

dgaudet     98/01/19 16:52:17

  Modified:    .        Tag: APACHE_1_2_X STATUS
               src      Tag: APACHE_1_2_X CHANGES http_protocol.c
  Log:
  r->connect->user allocated in wrong pool
  
  PR:		1500
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.1.2.18  +1 -0      apache/Attic/STATUS
  
  Index: STATUS
  ===================================================================
  RCS file: /export/home/cvs/apache/Attic/STATUS,v
  retrieving revision 1.1.2.17
  retrieving revision 1.1.2.18
  diff -u -r1.1.2.17 -r1.1.2.18
  --- STATUS	1998/01/20 00:49:34	1.1.2.17
  +++ STATUS	1998/01/20 00:52:12	1.1.2.18
  @@ -15,6 +15,7 @@
       * general/1666: basic auth token should be tested case-insensitive
       * protocol/1683: The Connection header may contain multiple close tokens
       * proxy was sending HTTP/1.1 responses in error
  +    * PR#1500: allocate r->connection->user in correct pool
   
   Available:
   
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.286.2.70 +3 -0      apache/src/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /export/home/cvs/apache/src/CHANGES,v
  retrieving revision 1.286.2.69
  retrieving revision 1.286.2.70
  diff -u -r1.286.2.69 -r1.286.2.70
  --- CHANGES	1998/01/20 00:49:36	1.286.2.69
  +++ CHANGES	1998/01/20 00:52:14	1.286.2.70
  @@ -1,5 +1,8 @@
   Changes with Apache 1.2.6
   
  +  *) r->connection->user was allocated in the wrong pool causing corruption
  +     in some cases when used with mod_cern_meta.  [Dean Gaudet] PR#1500
  +
     *) mod_proxy was sending HTTP/1.1 responses to ftp requests by mistake.
        Also removed the auto-generated link to www.apache.org that was the
        source of so many misdirected bug reports.  [Roy Fielding, Marc Slemko]
  
  
  
  1.126.2.10 +1 -1      apache/src/http_protocol.c
  
  Index: http_protocol.c
  ===================================================================
  RCS file: /export/home/cvs/apache/src/http_protocol.c,v
  retrieving revision 1.126.2.9
  retrieving revision 1.126.2.10
  diff -u -r1.126.2.9 -r1.126.2.10
  --- http_protocol.c	1998/01/20 00:35:18	1.126.2.9
  +++ http_protocol.c	1998/01/20 00:52:15	1.126.2.10
  @@ -936,7 +936,7 @@
       }
   
       t = uudecode (r->pool, auth_line);
  -    r->connection->user = getword_nulls_nc (r->pool, &t, ':');
  +    r->connection->user = getword_nulls_nc (r->connection->pool, &t, ':');
       r->connection->auth_type = "Basic";
   
       *pw = t;
  
  
  



---------- Forwarded message ----------
Date: 20 Jan 1998 00:54:42 -0000
From: dgaudet@hyperreal.org
To: apache-cvs@hyperreal.org
Subject: cvs commit: apache/src CHANGES http_protocol.c
Reply-To: new-httpd@apache.org

dgaudet     98/01/19 16:54:42

  Modified:    .        Tag: APACHE_1_2_X STATUS
               src      Tag: APACHE_1_2_X CHANGES http_protocol.c
  Log:
  send_fd_length() did not calculate total_bytes_sent properly.
  
  PR:           1366
  Submitted by: Ben Reser <breser@regnow.com>
  Reviewed by:  Dean Gaudet, Dirk-Willem van Gulik, Jim Jagielski
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.1.2.19  +1 -0      apache/Attic/STATUS
  
  Index: STATUS
  ===================================================================
  RCS file: /export/home/cvs/apache/Attic/STATUS,v
  retrieving revision 1.1.2.18
  retrieving revision 1.1.2.19
  diff -u -r1.1.2.18 -r1.1.2.19
  --- STATUS	1998/01/20 00:52:12	1.1.2.18
  +++ STATUS	1998/01/20 00:54:37	1.1.2.19
  @@ -16,6 +16,7 @@
       * protocol/1683: The Connection header may contain multiple close tokens
       * proxy was sending HTTP/1.1 responses in error
       * PR#1500: allocate r->connection->user in correct pool
  +    * PR#1366: send_fd_length did not calculate total_bytes_sent properly
   
   Available:
   
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.286.2.71 +3 -0      apache/src/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /export/home/cvs/apache/src/CHANGES,v
  retrieving revision 1.286.2.70
  retrieving revision 1.286.2.71
  diff -u -r1.286.2.70 -r1.286.2.71
  --- CHANGES	1998/01/20 00:52:14	1.286.2.70
  +++ CHANGES	1998/01/20 00:54:38	1.286.2.71
  @@ -1,4 +1,7 @@
   Changes with Apache 1.2.6
  +  
  +  *) send_fd_length() did not calculate total_bytes_sent properly in error
  +     cases.  [Ben Reser <breser@regnow.com>] PR#1366
   
     *) r->connection->user was allocated in the wrong pool causing corruption
        in some cases when used with mod_cern_meta.  [Dean Gaudet] PR#1500
  
  
  
  1.126.2.11 +1 -1      apache/src/http_protocol.c
  
  Index: http_protocol.c
  ===================================================================
  RCS file: /export/home/cvs/apache/src/http_protocol.c,v
  retrieving revision 1.126.2.10
  retrieving revision 1.126.2.11
  diff -u -r1.126.2.10 -r1.126.2.11
  --- http_protocol.c	1998/01/20 00:52:15	1.126.2.10
  +++ http_protocol.c	1998/01/20 00:54:39	1.126.2.11
  @@ -1588,12 +1588,12 @@
               break;
           }
           o=0;
  -	total_bytes_sent += n;
   
           while (n && !r->connection->aborted) {
               w = bwrite(r->connection->client, &buf[o], n);
               if (w > 0) {
                   reset_timeout(r); /* reset timeout after successful write */
  +		total_bytes_sent += w;
                   n-=w;
                   o+=w;
               }
  
  
  



---------- Forwarded message ----------
Date: 20 Jan 1998 00:59:13 -0000
From: dgaudet@hyperreal.org
To: apache-cvs@hyperreal.org
Subject: cvs commit: apache/src CHANGES alloc.c
Reply-To: new-httpd@apache.org

dgaudet     98/01/19 16:59:12

  Modified:    .        Tag: APACHE_1_2_X STATUS
               src      Tag: APACHE_1_2_X CHANGES alloc.c
  Log:
  Make table_{set,unset}() deal correctly with multiple occurrences of the
  same key.
  PR: 1604
  Submitted by: Stephen Scheck <sscheck@infonex.net>, Ben
  Reviewed by:  Ben Laurie, Dean Gaudetj
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.1.2.20  +1 -0      apache/Attic/STATUS
  
  Index: STATUS
  ===================================================================
  RCS file: /export/home/cvs/apache/Attic/STATUS,v
  retrieving revision 1.1.2.19
  retrieving revision 1.1.2.20
  diff -u -r1.1.2.19 -r1.1.2.20
  --- STATUS	1998/01/20 00:54:37	1.1.2.19
  +++ STATUS	1998/01/20 00:59:08	1.1.2.20
  @@ -17,6 +17,7 @@
       * proxy was sending HTTP/1.1 responses in error
       * PR#1500: allocate r->connection->user in correct pool
       * PR#1366: send_fd_length did not calculate total_bytes_sent properly
  +    * PR#1604: table_{set,unset} didn't deal correctly with multiple keys
   
   Available:
   
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.286.2.72 +4 -0      apache/src/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /export/home/cvs/apache/src/CHANGES,v
  retrieving revision 1.286.2.71
  retrieving revision 1.286.2.72
  diff -u -r1.286.2.71 -r1.286.2.72
  --- CHANGES	1998/01/20 00:54:38	1.286.2.71
  +++ CHANGES	1998/01/20 00:59:10	1.286.2.72
  @@ -1,4 +1,8 @@
   Changes with Apache 1.2.6
  +
  +  *) table_set() and table_unset() did not deal correctly with
  +     multiple occurrences of the same key. [Stephen Scheck
  +    <sscheck@infonex.net>, Ben Laurie] PR#1604
     
     *) send_fd_length() did not calculate total_bytes_sent properly in error
        cases.  [Ben Reser <breser@regnow.com>] PR#1366
  
  
  
  1.28.2.2  +12 -3     apache/src/alloc.c
  
  Index: alloc.c
  ===================================================================
  RCS file: /export/home/cvs/apache/src/alloc.c,v
  retrieving revision 1.28.2.1
  retrieving revision 1.28.2.2
  diff -u -r1.28.2.1 -r1.28.2.2
  --- alloc.c	1997/06/27 01:47:44	1.28.2.1
  +++ alloc.c	1998/01/20 00:59:11	1.28.2.2
  @@ -578,11 +578,12 @@
       table_entry *elts = (table_entry *)t->elts;
       int done = 0;
   
  -    for (i = 0; i < t->nelts; ++i)
  +    for (i = 0; i < t->nelts;) {
   	if (!strcasecmp (elts[i].key, key)) {
   	    if (!done) {
   	        elts[i].val = pstrdup(t->pool, val);
   	        done = 1;
  +		++i;
   	    }
   	    else {     /* delete an extraneous element */
                   for (j = i, k = i + 1; k < t->nelts; ++j, ++k) {
  @@ -592,6 +593,10 @@
                   --t->nelts;
   	    }
   	}
  +	else {
  +	    ++i;
  +	}
  +    }
   
       if (!done) {
           elts = (table_entry *)push_array(t);
  @@ -605,7 +610,7 @@
       register int i, j, k;   
       table_entry *elts = (table_entry *)t->elts;
    
  -    for (i = 0; i < t->nelts; ++i)
  +    for (i = 0; i < t->nelts;) {
           if (!strcasecmp (elts[i].key, key)) {
    
               /* found an element to skip over
  @@ -619,7 +624,11 @@
               }
               --t->nelts;
           }
  -}     
  +	else {
  +	    ++i;
  +	}
  +    }
  +}
   
   void table_merge (table *t, const char *key, const char *val)
   {
  
  
  



---------- Forwarded message ----------
Date: 20 Jan 1998 01:06:20 -0000
From: dgaudet@hyperreal.org
To: apache-cvs@hyperreal.org
Subject: cvs commit: apache/src CHANGES mod_digest.c
Reply-To: new-httpd@apache.org

dgaudet     98/01/19 17:06:20

  Modified:    .        Tag: APACHE_1_2_X STATUS
               src      Tag: APACHE_1_2_X CHANGES mod_digest.c
  Log:
  "digest" auth token should be tested case-insensitive as well.
  
  PR:		1599
  Submitted by:	Ronald.Tschalaer@psi.ch
  Reviewed by:	Dean Gaudet
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.1.2.21  +1 -0      apache/Attic/STATUS
  
  Index: STATUS
  ===================================================================
  RCS file: /export/home/cvs/apache/Attic/STATUS,v
  retrieving revision 1.1.2.20
  retrieving revision 1.1.2.21
  diff -u -r1.1.2.20 -r1.1.2.21
  --- STATUS	1998/01/20 00:59:08	1.1.2.20
  +++ STATUS	1998/01/20 01:06:16	1.1.2.21
  @@ -18,6 +18,7 @@
       * PR#1500: allocate r->connection->user in correct pool
       * PR#1366: send_fd_length did not calculate total_bytes_sent properly
       * PR#1604: table_{set,unset} didn't deal correctly with multiple keys
  +    * PR#1599: "Digest" auth token should be tested case-insensitive
   
   Available:
   
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.286.2.73 +2 -2      apache/src/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /export/home/cvs/apache/src/CHANGES,v
  retrieving revision 1.286.2.72
  retrieving revision 1.286.2.73
  diff -u -r1.286.2.72 -r1.286.2.73
  --- CHANGES	1998/01/20 00:59:10	1.286.2.72
  +++ CHANGES	1998/01/20 01:06:17	1.286.2.73
  @@ -18,8 +18,8 @@
        header, not an error, but a waste.
        [Ronald.Tschalaer@psi.ch] PR#1683
   
  -  *) "basic" auth token should be tested case-insensitive.
  -     [Ronald.Tschalaer@psi.ch] PR#1666
  +  *) "basic" and "digest" auth tokens should be tested case-insensitive.
  +     [Ronald.Tschalaer@psi.ch] PR#1599, PR#1666
   
     *) It appears the "257th byte" bug (see
        htdocs/manual/misc/known_client_problems.html#257th-byte) can happen
  
  
  
  1.14.2.1  +1 -1      apache/src/mod_digest.c
  
  Index: mod_digest.c
  ===================================================================
  RCS file: /export/home/cvs/apache/src/mod_digest.c,v
  retrieving revision 1.14
  retrieving revision 1.14.2.1
  diff -u -r1.14 -r1.14.2.1
  --- mod_digest.c	1997/03/07 14:15:39	1.14
  +++ mod_digest.c	1998/01/20 01:06:18	1.14.2.1
  @@ -145,7 +145,7 @@
       return AUTH_REQUIRED;
     }
   
  -  if (strcmp(getword (r->pool, &auth_line, ' '), "Digest")) {
  +  if (strcasecmp(getword (r->pool, &auth_line, ' '), "Digest")) {
       /* Client tried to authenticate using wrong auth scheme */
       log_reason ("client used wrong authentication scheme", r->uri, r);
       note_digest_auth_failure (r);
  
  
  



---------- Forwarded message ----------
Date: 20 Jan 1998 01:09:41 -0000
From: dgaudet@hyperreal.org
To: apache-cvs@hyperreal.org
Subject: cvs commit: apache/src CHANGES http_main.c
Reply-To: new-httpd@apache.org

dgaudet     98/01/19 17:09:41

  Modified:    src      Tag: APACHE_1_2_X CHANGES http_main.c
  Log:
  When an error occurs in fcntl() locking suggest the user look up
  the docs for LockFile.
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.286.2.74 +4 -1      apache/src/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /export/home/cvs/apache/src/CHANGES,v
  retrieving revision 1.286.2.73
  retrieving revision 1.286.2.74
  diff -u -r1.286.2.73 -r1.286.2.74
  --- CHANGES	1998/01/20 01:06:17	1.286.2.73
  +++ CHANGES	1998/01/20 01:09:38	1.286.2.74
  @@ -1,8 +1,11 @@
   Changes with Apache 1.2.6
   
  +  *) When an error occurs in fcntl() locking suggest the user look up
  +     the docs for LockFile.  [Dean Gaudet]
  +
     *) table_set() and table_unset() did not deal correctly with
        multiple occurrences of the same key. [Stephen Scheck
  -    <sscheck@infonex.net>, Ben Laurie] PR#1604
  +     <sscheck@infonex.net>, Ben Laurie] PR#1604
     
     *) send_fd_length() did not calculate total_bytes_sent properly in error
        cases.  [Ben Reser <breser@regnow.com>] PR#1366
  
  
  
  1.149.2.11 +6 -4      apache/src/http_main.c
  
  Index: http_main.c
  ===================================================================
  RCS file: /export/home/cvs/apache/src/http_main.c,v
  retrieving revision 1.149.2.10
  retrieving revision 1.149.2.11
  diff -u -r1.149.2.10 -r1.149.2.11
  --- http_main.c	1997/09/22 21:58:51	1.149.2.10
  +++ http_main.c	1998/01/20 01:09:39	1.149.2.11
  @@ -236,8 +236,9 @@
   	continue;
   
       if (ret < 0) {
  -	log_unixerr("fcntl", "F_SETLKW", "Error getting accept lock. Exiting!",
  -		    server_conf);
  +	log_unixerr("fcntl", "F_SETLKW", "Error getting accept lock. Exiting!"
  +		    "Perhaps you need to use the LockFile directive to place "
  +		    "your lock file on a local disk!", server_conf);
   	exit(1);
       }
   }
  @@ -246,8 +247,9 @@
   {
       if (fcntl (lock_fd, F_SETLKW, &unlock_it) < 0)
       {
  -	log_unixerr("fcntl", "F_SETLKW", "Error freeing accept lock. Exiting!",
  -		    server_conf);
  +	log_unixerr("fcntl", "F_SETLKW", "Error freeing accept lock. Exiting!"
  +		    "Perhaps you need to use the LockFile directive to place "
  +		    "your lock file on a local disk!", server_conf);
   	exit(1);
       }
   }
  
  
  


Mime
View raw message