httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Hartill <r...@imdb.com>
Subject Re: [PATCH] 7% to 25% performance improvement
Date Sun, 25 Jan 1998 01:09:30 GMT
On Sat, 24 Jan 1998, Dean Gaudet wrote:

> This patch is based on code submitted by Dmitry Khrustalev
> <dima@bog.msu.su>.  The table_(set|add|merge) routines all do pstrdup() 
> of their key and val.  But this isn't always required... in fact it's
> almost never required.  In many of the cases where these routines are
> called the key is a constant string, and the value has been constructed by
> pstrcat() or getword() or something else which has already allocated in
> the appropriate pool. 

bummer. It patched clean but mod_perl needs to be changed too:

perl_config.c: In function `mod_perl_dir_env':
perl_config.c:167: dereferencing pointer to incomplete type
perl_config.c:169: dereferencing pointer to incomplete type
*** Error code 1

=====
  void mod_perl_dir_env(perl_dir_config *cld)
  { 
      if(MP_HASENV(cld)) { 
*     table_entry *elts = (table_entry *)cld->env->elts;
      int i;
*     for (i = 0; i < cld->env->nelts; ++i) {
          MP_TRACE(fprintf(stderr, "mod_perl_dir_env: %s=`%s'",
                   elts[i].key, elts[i].val));
          mp_setenv(elts[i].key, elts[i].val);
      } 
      MP_HASENV_off(cld); /* just doit once per-request */
      }
  }
=====

what do I change it to ?

--
Rob Hartill                              Internet Movie Database (Ltd)
http://www.moviedatabase.com/   .. a site for sore eyes.


Mime
View raw message