httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <>
Subject Re: [PATCH] CGI: script command line and win32
Date Sat, 10 Jan 1998 00:11:48 GMT
On Fri, 9 Jan 1998, Dean Gaudet wrote:

> One questions the sense of even voting on these things if you don't test
> them.  What does this gain us over just committing and testing later? 
> Nothing imnsho.  I know I vote without testing, so I'm not picking on you
> two, I'm just questioning what voting is even useful for.
> On the other hand if you don't vote when you haven't tested then the
> project stalls.  Whereas if it had just been committed the project
> continues and some other person (who doesn't necessarily have time to
> follow every single commit) gets to test the code by grabbing the latest
> HEAD. 

Note that NT stuff is already committed without 3 +1s because it almost
has to be.

You shouldn't +1 unless you actually have gone through the code fully.
That is why I often skip +1ing.  +1s on concepts are not sufficient to use
for committing.

OTOH, we don't have a huge number of people to sit around reviewing code
all the time so we don't get +1s on valid code.  This especially stands
out on NT since I doubt we have three competent NT developers who are
group members (yes, we probably do on the mailing list total but that is
another matter...)  I'm not. 

View raw message