httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: [PATCH] new_connection -> ap_new_connection name change
Date Sun, 18 Jan 1998 12:36:27 GMT
Doug MacEachern wrote:
> 
> Rodent of Unusual Size wrote:
> 
> > Rasmus Lerdorf wrote:
> > >
> > > Ok, how about just making it static then?  If it will never be used
> > > outside of that file that should take care of it.
> >
> > If it's never used anywhere else then that's definitely the
> > preferred solution to my mind.  +1 - but I can't verify the
> > source at this moment.
> 
> Please don't!!!  The DCE module (discussed a while back, which uses dce
> rpc, not tcp, sfio, etc.), calls new_connection() in it's
> -DSTANDALONE_MAIN function.  Rename is little trouble, but static'izing
> new_connection() would be a nightmare.  I vote for httpd_new_connection,
> or something like that.

The only problem I have with this is that httpd_ does not obviously mean
that the thing is private to apache. How about ap_private_?

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author
A.L. Digital Ltd,     |http://www.algroup.co.uk/Apache-SSL
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Mime
View raw message