httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug MacEachern <do...@telebusiness.co.nz>
Subject Re: [PATCH] Improve implementation of -c/-Cdirective reading
Date Thu, 15 Jan 1998 22:24:23 GMT
Martin Kraemer wrote:

> *** WARNING *** THIS PATCH BREAKS MOD_PERL *** WARNING ***
>
> The recently added -C/-c directive handling has a few bugs I didn't
> notice at the time they were added:

sheesh, I am cursed, I can't even apply your patch to fix all the bugs I
added ;-(+1 on concept.   the patch makes one .rej files which I applied by
hand, but my sore eyes can't see what's wrong:
util.c: In function `pcfg_openfile':
util.c:715: parse error before `*'
util.c:726: `param' undeclared (first use this function)
util.c:726: (Each undeclared identifier is reported only once
util.c:726: for each function it appears in.)
util.c:727: `descr' undeclared (first use this function)
util.c:728: `getch' undeclared (first use this function)
util.c:729: `getstr' undeclared (first use this function)
util.c:730: `close_func' undeclared (first use this function)

It's been a long week and late night, could you just send me your util.c so I
can test?

> That is because I switched to using srm_command_loop(). But the perl
> hook was coded into the explicit
>     while (array has more lines) handle_command()
> loop. I think it did NOT belong there!
>
> Can one of the perl gurus please have a look at the proper place where
> the "PerlModule" command could be checked? Is it in srm_command_loop()?

isokay, the #ifdef MOD_PERL isn't needed anymore.

-Doug


Mime
View raw message