httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: cvs commit: apachen STATUS
Date Fri, 09 Jan 1998 14:55:58 GMT
Marc Slemko wrote:
> 
> On Fri, 9 Jan 1998, Martin Kraemer wrote:
> 
> > On Thu, Jan 08, 1998 at 08:04:04PM -0600, Randy Terbush wrote:
> > > #ifdef'd code is a good suggestion for developing code. We've resisted
> > > this for some reason but I strongly support doing this when possible.
> >
> > But in the review-then-commit model, you can easily add new #ifdefs
> > (I added #ifdef WITH_UTIL_URI in my sources to en/disable the util_uri
> > changes). So, there must be a way to _remove_ the #ifdefs again (in fact,
> > remove the #else branch ;-) once the code is settled. Otherwise, the apache
> > code will soon be cluttered with hundreds of #ifdef MARTINS_TEST_FEATURE_17
> > etc.
> 
> And I am very worried about that.  The code is already cluttered and there
> are some things that need cleaning up...

And if we operated commit-then-review there'd be more chance they got
cleaned up...

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author
A.L. Digital Ltd,     |http://www.algroup.co.uk/Apache-SSL
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Mime
View raw message