httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@engelschall.com (Ralf S. Engelschall)
Subject Re: [PATCH] make mod_rewrite use ap_cpystrn
Date Sat, 10 Jan 1998 13:09:07 GMT

In article <Pine.LNX.3.95dg3.980107182931.5827H-100000@twinlark.arctic.org> you wrote:

> Well I haven't tested this because I realised that Ralf is still in the
> middle of a mod_rewrite restructuring... is that true?  If so do you have
> a patch we can commit so I can continue performance tuning? 

You can continue Dean because all still valid stuff is still comitted and the
"splitting into modules/rewrite/" part has to be redone completely (because I
had to stop it in the past to be able to independently commit the previous
work as Ken and others wanted in the past).

So, go on and do performance tuning, Dean ;_)

> At any rate, you'll note some speedups in this because of the useful
> return value from ap_cpystrn.  In particular variable expansion is now
> O(n) instead of O(n**2).  There's a bunch of cases where mod_rewrite uses
> strlen() which could be sped up.

> But I'm not committing it without Ralf's ok.

I've reviewed your code and looks ok. Great work. +1
Even if I haven't tested it in your life....

Greetings,
                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message