httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <Martin.Krae...@mch.sni.de>
Subject Re: cvs commit: apachen STATUS
Date Fri, 09 Jan 1998 09:14:40 GMT
On Thu, Jan 08, 1998 at 08:04:04PM -0600, Randy Terbush wrote:
> #ifdef'd code is a good suggestion for developing code. We've resisted
> this for some reason but I strongly support doing this when possible.

But in the review-then-commit model, you can easily add new #ifdefs
(I added #ifdef WITH_UTIL_URI in my sources to en/disable the util_uri
changes). So, there must be a way to _remove_ the #ifdefs again (in fact,
remove the #else branch ;-) once the code is settled. Otherwise, the apache
code will soon be cluttered with hundreds of #ifdef MARTINS_TEST_FEATURE_17
etc.

   Martin
-- 
| S I E M E N S |  <Martin.Kraemer@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

Mime
View raw message