httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <Martin.Krae...@mch.sni.de>
Subject Re: [PATCH] yet another slow function
Date Wed, 07 Jan 1998 12:16:44 GMT
On Tue, Jan 06, 1998 at 03:49:28PM -0800, Dean Gaudet wrote:
> On Tue, 6 Jan 1998, Brian Behlendorf wrote:
> > Couldn't we have safe_path_chars created by that cute program of yours at
> > startup time?   Wouldn't that be safer if used on other character sets, or
> > EBCDIC?
>
> Yes we could... and actually, consider that a patch in progress.  I'm
> going to nail a lot more uses of ind.

Yeah, of course I could #ifdef CHARSET_EBCDIC the generated table; but
I'd prefer the dynamic version too. Are there any init-hooks for various parts
of apache? 

> strchr() is standard and faster than ind on many boxes... at least on
> those where the vendor took the time to code it into assembly ;)

Hmm.. Then why aren't ind() and rind() based on strchr() and strrchr()?
We don't have to code apache in assembler ;-)

    Martin
-- 
| S I E M E N S |  <Martin.Kraemer@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

Mime
View raw message