Message-ID: <3493C221.433788D9@algroup.co.uk>
Date: Sun, 14 Dec 1997 11:25:21 +0000
From: Ben Laurie <ben@algroup.co.uk>
Organization: A.L. Digital Ltd.
MIME-Version: 1.0
To: new-httpd@apache.org
Subject: Re: [PATCH] PR#1319: RedirectMatch gone / causes SIGSEGV
References: <Pine.LNX.3.95dg3.971213175050.11435Q-100000@twinlark.arctic.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

Dean Gaudet wrote:
> 
> RedirectMatch gone / causes a SIGSEGV.  This is fixed here.
> 
> But when I was testing Redirect gone / I found it wasn't working right...
> it turns out to be a bug introduced by a change to alloc.c between
> revisions 1.41 and 1.42 -- Stanley Gambarin pointed out that pstrcat(p,
> NULL) returned bogosity (an uninitialized byte) and suggested that it
> return NULL in this case.  I put that in... but it turns out that
> mod_alias was relying on it returning something non-NULL even in this
> case.  So this patch includes a tweak which causes pstrcat(p, NULL) to
> return an empty string... which should be more compatible.

+1 (untested).

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author
A.L. Digital Ltd,     |http://www.algroup.co.uk/Apache-SSL
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache