httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] a bundle of multithreading changes
Date Mon, 01 Dec 1997 19:20:38 GMT
I haven't looked at the patch yet, but the feature list looks really good
:)  Thanks for tracking the unix work. 

On Mon, 1 Dec 1997, Paul Sutton wrote:

>  - In child_sub_main() (the "worker" thread code) used ptrans for
>    the temporary pool, instead of pchild - now consistent with
>    Unix child_main() [Incidently I'm not sure why ptrans is a global,
>    since it (should) only be used within child_main()?]

ptrans is static now after my changes that created pchild.  I think if you
make it local to child_main you end up with setjmp/longjmp issues. 

> On the downside, this patch
> 
>  - Makes the MT code more Win32 specific (this is necessary since
>    it is useful to do WaitForMultipleObject() type things, for instance,
>    and we don't have an abstraction for that). Also the Win32 stuff should
>    use completion ports, and again we don't have an abstraction. However
>    this does give us a good idea of stuff that does need abstracting.

I've never thought of the MULTITHREAD define as meaning anything other
than "win32 multithread"... for 1.3 at least I don't see any hassles in
making that assumption.  For 2.0 I don't want these sorts of #ifdefs
littered all over, I really hope the api can abstract them away behind the
covers. 

Dean


Mime
View raw message