httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: suexec/1543: suexec.c -- Does not report exec failure reasons (fwd)
Date Sat, 13 Dec 1997 22:07:25 GMT
Marc Slemko wrote:
> 
> Why would any compiler do this?  I'm no compiler expert, but I fail to see
> how any sane compiler would do this.

I don't see how this can be to do with the compiler. In fact, I don't
even understand the bug report.

Cheers,

Ben.

> 
> ---------- Forwarded message ----------
> Date: Fri, 12 Dec 97 11:41:44 PST
> From: "M. D. Parker" <mdpc@netcom.com>
> To: Marc Slemko <marcs@znep.com>
> Cc: apbugs@hyperreal.org
> Subject: Re: suexec/1543: suexec.c -- Does not report exec failure reasons
> 
> Problem with the patch seems to be in the evaluation of the parameters
> pushed onto the stack before the call.  It seems that at least in my gcc
> implementation, the value of errno gets changed before being printed out,
> but the strerror() call reports the right textual error.
> 
> Suggest that you change the patch as follows:
> 
> .
> .
> .
> int errx;       /* error numb holder */
> .
> .
> .
>         errx=errno;
>     log_err("(%d)%s: exec failed (%s)\n", errx, strerror(errx), cmd);
> 
> Mike

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author
A.L. Digital Ltd,     |http://www.algroup.co.uk/Apache-SSL
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Mime
View raw message