httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: [PATCH] Proper reporting of Win32 errors
Date Mon, 01 Dec 1997 17:23:22 GMT
Martin Kraemer wrote:
> 
> On Mon, Dec 01, 1997 at 10:47:00AM +0000, Paul Sutton wrote:
> > The patch below updates aplog_error() to enable generic logging of
> > Win32 errors to the same place as other errors. It adds a new flag,
> > APLOG_WIN32ERROR
> 
> Generally, I'm +1 on this change. After what I've seen from the
> Win32 SDK, I see no alternative than to flag each situation where
> GetLastError() returns a valid value; there seems to be no "general"
> case for error reporting. Even worse, WinSock "system" calls
> apparently need a call to WSAGetLastError() instead of
> GetLastError() to query the error number, don't we need an extra bit
> for these as well (or is WSAGetLastError() and GetLastError()
> equivalent)?

WSAGetLastError() and GetLastError() are not equivalent. I proved this
to myself when debugging the 16k problem...

That said, Unix is not blameless in this area (cf. errno versus herrno).

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author
A.L. Digital Ltd,     |http://www.algroup.co.uk/Apache-SSL
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Mime
View raw message