httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: ap_cpystrn
Date Tue, 30 Dec 1997 21:34:49 GMT
Ben Laurie wrote:
> 
> Jim Jagielski wrote:
> > 
> > Jim Jagielski wrote:
> > >
> > > Dean Gaudet wrote:
> > > >
> > > > I just committed some off-by-1 fixes for the new ap_cpystrn code...
> > > > induced I'm sure by my request that ap_cpystrn guarantee the \0
> > > > termination.
> > > >
> > >
> > > Yeah...
> > >
> > 
> > Also by what 'len' stands for :)
> 
> Yeah, but Dean is right. len should be the length of the buffer. I hate
> all this +1, -1 business.
> 

I agree... That's what ap_cpystrn() uses it as now, and it even
calls it something like dst_size just to remind people... I just
forgot it in the calls :)

-- 
====================================================================
      Jim Jagielski            |       jaguNET Access Services
     jim@jaguNET.com           |       http://www.jaguNET.com/
            "Look at me! I'm wearing a cardboard belt!"

Mime
View raw message