httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <>
Subject Re: strncpy is evil
Date Tue, 23 Dec 1997 20:30:08 GMT
Dean Gaudet wrote:
> Oh yeah I was just goofing around, if I do this for real I'll also go
> whack every single occurance of strncpy in the code and replace it with
> ap_copystr or something...

Just be careful... When I post pseudo-code to give a feel,
I invariably foul up. :)

> I want to avoid a standard name on this one so
> that folks know it has different semantics.
> I'm not sure I'm advocating these for 1.3.  I'd love to get the
> "non-aggressive" optimizations in though... by "aggressive" I mean ones
> which are not necessarily right for all setups... like the mod_include one
> ;)

Well, I'm advocating the strncpy stuff for 1.3... Your recent benchmarks
seemed pretty convincing.

      Jim Jagielski            |       jaguNET Access Services           |
            "Look at me! I'm wearing a cardboard belt!"

View raw message