httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <Martin.Krae...@mch.sni.de>
Subject Re: [PATCH] Proper reporting of Win32 errors
Date Mon, 01 Dec 1997 16:03:23 GMT
On Mon, Dec 01, 1997 at 10:47:00AM +0000, Paul Sutton wrote:
> The patch below updates aplog_error() to enable generic logging of 
> Win32 errors to the same place as other errors. It adds a new flag,
> APLOG_WIN32ERROR

Generally, I'm +1 on this change. After what I've seen from the
Win32 SDK, I see no alternative than to flag each situation where
GetLastError() returns a valid value; there seems to be no "general"
case for error reporting. Even worse, WinSock "system" calls
apparently need a call to WSAGetLastError() instead of
GetLastError() to query the error number, don't we need an extra bit
for these as well (or is WSAGetLastError() and GetLastError()
equivalent)?

    Martin
-- 
| S I E M E N S |  <Martin.Kraemer@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

Mime
View raw message