Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 10896 invoked by uid 6000); 22 Nov 1997 02:05:53 -0000 Received: (qmail 10890 invoked from network); 22 Nov 1997 02:05:52 -0000 Received: from twinlark.arctic.org (305@204.62.130.91) by taz.hyperreal.org with SMTP; 22 Nov 1997 02:05:52 -0000 Received: (qmail 13992 invoked by uid 500); 22 Nov 1997 02:08:31 -0000 Date: Fri, 21 Nov 1997 18:08:31 -0800 (PST) From: Dean Gaudet To: new-httpd@apache.org Subject: Re: [PATCH] remove explain.c, do it with aplog_error() In-Reply-To: <19971121223135.60445@deejai.mch.sni.de> Message-ID: Legal: "Copyright (c) 1997 Dean Gaudet, all rights reserved. Visit http://www.arctic.org/~dgaudet/legal for more information." Organization: Transmeta Corp. MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="AP2g/MAC+5xKAEJP" Content-ID: Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --AP2g/MAC+5xKAEJP Content-Type: TEXT/PLAIN; CHARSET=us-ascii Content-ID: +1 ... btw http_main used to use explain, but I didn't maintain it when I was rewriting the main loop in standalone_main. Dean On Fri, 21 Nov 1997, Martin Kraemer wrote: > On Fri, Nov 21, 1997 at 10:30:07PM +0100, Martin Kraemer wrote: > > explain.c, as someone (Roy? Jim?) mentioned before, is not a very useful > > debugging tool, and only mod_proxy uses it at all. > > > > Here is a patch to replace the functionality by aplog_error, preserving > > the interface as it is now. > Oops -- here comes. > > Martin > -- > | S I E M E N S | | Siemens Nixdorf > | ------------- | Voice: +49-89-636-46021 | Informationssysteme AG > | N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany > ~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request > --AP2g/MAC+5xKAEJP Content-Type: TEXT/PLAIN; CHARSET=us-ascii Content-ID: Content-Description: --- /usr/src/apachen/src/main/explain.h Fri Oct 10 15:13:27 1997 +++ main/explain.h Tue Nov 11 21:59:35 1997 @@ -8,17 +8,22 @@ #define Explain5(f,a1,a2,a3,a4,a5) #define Explain6(f,a1,a2,a3,a4,a5,a6) #else -#define DEF_Explain static const char *__ExplainFile=__FILE__; -void _Explain(const char *szFile, int nLine, const char *szFmt,...) - __attribute__((format(printf,3,4))); -#define Explain0(f) _Explain(__ExplainFile,__LINE__,f) -#define Explain1(f,a1) _Explain(__ExplainFile,__LINE__,f,a1) -#define Explain2(f,a1,a2) _Explain(__ExplainFile,__LINE__,f,a1,a2) -#define Explain3(f,a1,a2,a3) _Explain(__ExplainFile,__LINE__,f,a1,a2,a3) -#define Explain4(f,a1,a2,a3,a4) _Explain(__ExplainFile,__LINE__,f,a1,a2,a3,a4) +#define DEF_Explain +#define Explain0(f) aplog_error(APLOG_MARK, APLOG_DEBUG|APLOG_NOERRNO, NULL, \ + f) +#define Explain1(f,a1) aplog_error(APLOG_MARK, APLOG_DEBUG|APLOG_NOERRNO, NULL, \ + f,a1) +#define Explain2(f,a1,a2) aplog_error(APLOG_MARK, APLOG_DEBUG|APLOG_NOERRNO, NULL, \ + f,a1,a2) +#define Explain3(f,a1,a2,a3) aplog_error(APLOG_MARK, APLOG_DEBUG|APLOG_NOERRNO, NULL, \ + f,a1,a2,a3) +#define Explain4(f,a1,a2,a3,a4) aplog_error(APLOG_MARK, APLOG_DEBUG|APLOG_NOERRNO, NULL, \ + f,a1,a2,a3,a4) #define Explain5(f,a1,a2,a3,a4,a5) \ - _Explain(__ExplainFile,__LINE__,f,a1,a2,a3,a4,a5) + aplog_error(APLOG_MARK, APLOG_DEBUG|APLOG_NOERRNO, NULL, \ + f,a1,a2,a3,a4,a5) #define Explain6(f,a1,a2,a3,a4,a5,a6) \ - _Explain(__ExplainFile,__LINE__,f,a1,a2,a3,a4,a5,a6) + aplog_error(APLOG_MARK, APLOG_DEBUG|APLOG_NOERRNO, NULL, \ + f,a1,a2,a3,a4,a5,a6) #endif --AP2g/MAC+5xKAEJP--