httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <Martin.Krae...@mch.sni.de>
Subject Re: [PATCH] "Signing" server generated pages
Date Tue, 04 Nov 1997 16:41:46 GMT
On Mon, Nov 03, 1997 at 09:59:49PM +0100, Lars Eilebrecht wrote:
> I like the idea, but only if we talk about error-pages and FTP listings.
> IMHO it may not look good on directory listings if a README is included
> at the bottom.

Yes, I thought about that as well -- I wanted to include the footer only
if no README was present. But look at the code:

    if (autoindex_opts & FANCY_INDEXING) {
	if ((tmp = find_readme(autoindex_conf, r)))
	    insert_readme(name, tmp, "", HRULE, END_MATTER, r);
	else {
	    rputs("</UL>", r);  /* XXX: @@@@ This is bogus - there was no UL */
	}
    }
The </UL> is bogus because it doesn't close any pending <UL>.
OTOH, with or without a README file, I never succeeded in getting apache
to execute this rputs() statement at all! I had tried to add my footer
there, but it never appeared.

So: BIG question to everyone:
WHY IS the else-branch of "if (..find_readme(...))" never executed?
Anyone?

> Maybe you should only use SERVER_BASEVERSION instead of SERVER_VERSION,
> because the SUBVERSION can get very long in some cases.

    Done.

> How about something Squid-like?
> 
>   "Generated by Apache/1.3b3@www.foo.bar"

Hmm... -0.5

    Martin
-- 
| S I E M E N S |  <Martin.Kraemer@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

Mime
View raw message