httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] Line Numbers are counted wrong in config file parsing
Date Wed, 22 Oct 1997 16:22:23 GMT
Rewriting cfg_getline's interface would let you also implement the parser
changes that Rob/Doug want for mod_perl... i.e. put a callback into it
which is normally bgets() but can be substituted with something else.  You
probably want a separate cfg_getline in that case. 

Oh yeah +1 on the patch though, these are bugs which I fixed ages ago in
my TRACE_MERGE patch which I never did finish up, and I meant to pull them
out of the patch and submit them.  You beat me to it :) 

Dean

On Wed, 22 Oct 1997, Martin Kraemer wrote:

> Forget the patch.... I just realized that cfg_getline() is called at
> _many_ places (mod_*.c). I'll rethink my argument....
> 
> > The best solution IMHO would be to add the line counting to cfg_getline()
> > where the '\n' is detected, but that would have required an interface
> > change.
> 
> ...and will rewrite the interface of cfg_getline(), I guess.
> 
> Or shouldn't I?
> 
>     Martin
> -- 
> | S I E M E N S |  <Martin.Kraemer@mch.sni.de>  |      Siemens Nixdorf
> | ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
> | N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
> ~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
> 


Mime
View raw message