httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] mod_speling loglevels
Date Sun, 19 Oct 1997 06:27:14 GMT
+1

On Sat, 18 Oct 1997, Lars Eilebrecht wrote:

> Hi,
> 
> mod_speling logs information about fixed spelling errors and issued
> candidate lists to the error log, but uses APLOG_ERR rsp. APLOG_WARNING
> which is in my eyes not appropriate.
> 
> People who use mod_speling will see a lot of such messages... but
> they don't represent an error or warning condition (IMHO).
> They are only informational... therefore APLOG_INFO should be used.
> 
> Patch appended below.
> 
> ciao...
> -- 
> Lars Eilebrecht
> sfx@unix-ag.org
> 
> ---------------------------------------------------------------------------
> 
> Index: apachen/src/modules/standard/mod_speling.c
> ===================================================================
> RCS file: /cvs/apachen/src/modules/standard/mod_speling.c,v
> retrieving revision 1.5
> diff -u -r1.5 mod_speling.c
> --- mod_speling.c	1997/10/07 05:27:32	1.5
> +++ mod_speling.c	1997/10/18 12:15:36
> @@ -340,7 +340,7 @@
>              table_set(r->headers_out, "Location",
>                        construct_url(r->pool, nuri, r->server));
>  
> -            aplog_error(APLOG_MARK, APLOG_NOERRNO|APLOG_ERR, r->server,
> +            aplog_error(APLOG_MARK, APLOG_NOERRNO|APLOG_INFO, r->server,
>                          ref ? "Fixed spelling: %s to %s from %s"
>                          : "Fixed spelling: %s to %s",
>                          r->uri, nuri, ref);
> @@ -401,7 +401,7 @@
>              /* Pass our table to http_protocol.c (see mod_negotiation): */
>              table_set(notes, "variant-list", t);
>  
> -            aplog_error(APLOG_MARK, APLOG_NOERRNO|APLOG_WARNING, r->server,
> +            aplog_error(APLOG_MARK, APLOG_NOERRNO|APLOG_INFO, r->server,
>                          ref ? "Spelling fix: %s: %d candidates from %s"
>                          : "Spelling fix: %s: %d candidates",
>                          r->uri, candidates->nelts, ref);
> 


Mime
View raw message