httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] vhost revamp (take 2)
Date Tue, 07 Oct 1997 18:56:15 GMT
Cool, I'm glad folks are happy with it.

On Tue, 7 Oct 1997, Martin Kraemer wrote:

> 
> Should there possibly be a warning in here, too? Something like...
> 		aplog_error(APLOG_MARK, APLOG_NOERRNO|APLOG_WARN, main_s,
> 		    "VirtualHost has no ServerName configured, "
> 		    "and unable to resolve server name for %s (check DNS)",
> 		    inet_ntoa(s->addrs->host_addr));

There's already a warning because the host has no s->addrs, we don't allow
people to do "<VitualHost >", and if they do "<VirtualHost foo>" and foo
doesn't resolve they get a warning then.  This little bit of code is just
to protect s->server_hostname from being null.

Dean


Mime
View raw message