httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: pre-patch: struct sockaddr_in error messages
Date Fri, 24 Oct 1997 19:50:08 GMT
Jim Jagielski wrote:
> 
> Paul Sutton wrote:
> >
> > On Fri, 24 Oct 1997, Jim Jagielski wrote:
> > > Martin Kraemer wrote:
> > > > On Fri, Oct 24, 1997 at 12:42:42AM -0700, Dean Gaudet wrote:
> > > > > This patch adds two extensions to ap_snprintf:
> > > > >
> > > > > This is either a feature, or part of the log cleanup.  Take yer pick.
> > > > +4!  Put it in now, not for 2.0!           ^^^^^^^^^^^
> > >
> > > ap_snprintf is a replacement for those OSs that lack a working
> > > snprintf(). These add 2 extensions to it. At that point it
> > > stops being a replacement, since OSs that already have a
> > > snprintf() will _need_ to use this one.
> >
> > +1 for the functionality of logging client addresses, but I'm also worried
> > about making ap_snprintf customised. Can't this be done by adding another
> > flag to aplog_error instead - just like APLOG_ERRNO, which also adds
> > specific information to the log. E.g.
> >
> 
> That would be cool... Dean?

Not convinced. The argument about our snprintf being broken but the
existing one not is spurious. If any of our code is broken, the user is
scuppered.

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author
A.L. Digital Ltd,     |http://www.algroup.co.uk/Apache-SSL
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Mime
View raw message