httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <Martin.Krae...@mch.sni.de>
Subject Re: [PATCH] Minor cleanups for portability
Date Fri, 31 Oct 1997 09:48:01 GMT
Uh oh. Forgot to append the patch again...

On Fri, Oct 31, 1997 at 10:24:33AM +0100, Martin Kraemer wrote:
> The appended patch addresses the following portability problems:
> 
> *   There's a read() to a int dummybuf[] in http_main.c; when the read()
>     is prototyped with int read(int,char*,size_t) then the second parameter
>     (int*) is mismatched. Changing the dummybuf to char[] helps, and it's
>     otherwise unused anyway.
> 
> *   Explain.c includes explain.h which uses the __attribute__() construct.
>     However, conf.h (or httpd.h) was not included before, so explain.c
>     lacks the OS-specific definition of ap_inline and __attribute__().
>     The patch includes "httpd.h" first (and thus holds the promise that
>     os.h will be included in every .c file, too ;-)
> 
>     Martin
> -- 
> | S I E M E N S |  <Martin.Kraemer@mch.sni.de>  |      Siemens Nixdorf
> | ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
> | N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
> ~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

-- 
| S I E M E N S |  <Martin.Kraemer@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

Mime
View raw message