httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@engelschall.com (Ralf S. Engelschall)
Subject Re: Overhauling mod_rewrite !!
Date Wed, 29 Oct 1997 18:28:50 GMT

In article <009BC7EA7483AB63.51C1@PROCESS.COM> you wrote:
> From the fingers of Ralf S. Engelschall flowed the following:
>>
>>Then I finished Roys intenting stuff and the "cvs diff" was even more
>>horrible.

>     Please don't try to combine indenting with code changes.  I'd
>     suggest committing the indent first, and then doing the changes -
>     that way at least the code is clean in CVS even if your changes
>     aren't voted in.  (I've been hammered on this one a couple of times
>     meself.)

The indenting comes with the code splitting, because of the splitting I had to
rename a lot of things and rearrange comments, etc. Although I see your point
and think is is useful, the only thing possible is to commit the new
"bugfixed" apply_rewrite_rule() function. But I don't wanted to finish the
indenting and then start splitting, so I'd done it mostly in parallel to safe
time.

>>Hmmm... currently I'm not finished, but my new modules/rewrite/ directory
>>looks like this:
>>
>>-rw-r--r--  1 rse  wheel   1459 Oct 29 16:29 Makefile
>>-rw-r--r--  1 rse  wheel    427 Oct 29 17:06 Makefile.tmpl
>>-rw-r--r--  1 rse  wheel   1857 Oct 29 17:05 README
>>-rw-r--r--  1 rse  wheel  18594 Oct 29 17:04 librewrite.a
>>-rw-r--r--  1 rse  wheel  15034 Oct 29 17:09 rewrite.h
>>-rw-r--r--  1 rse  wheel  30014 Oct 29 17:10 rewrite_apibase.c
>>-rw-r--r--  1 rse  wheel  23021 Oct 29 17:10 rewrite_apihook.c
>>-rw-r--r--  1 rse  wheel   3196 Oct 29 16:47 rewrite_cache.c
>>-rw-r--r--  1 rse  wheel  26345 Oct 29 16:54 rewrite_engine.c
>>-rw-r--r--  1 rse  wheel   8333 Oct 29 17:04 rewrite_engine.o
>>-rw-r--r--  1 rse  wheel   7254 Oct 29 16:26 rewrite_logfile.c
>>-rw-r--r--  1 rse  wheel  26430 Oct 29 16:49 rewrite_mapfile.c
>>-rw-r--r--  1 rse  wheel   9144 Oct 29 17:10 rewrite_misc.c
>>-rw-r--r--  1 rse  wheel   5170 Oct 29 16:10 rewrite_uri.c

>     Please rename the file that contains the "module" declaration to
>     "mod_rewrite.c" so <IfModule> blocks can use the same convention
>     (i.e., "<IfModule mod_mumble.c>") for this as for other modules.
>     Other than that, I rather like the compartmentalisation.

Would be rewrite_apibase.c -> mod_rewrite.c. Ok, no problem.

>     I'm not in a position to test the restructured tree at this point,
>     but I'm conceptually +1 on this - if all the Configure stuff
>     continues to work properly.

The Unix part, yes. The Windows NT part someone else has to create, because I
don't have the tools for this (NMake, DS, etc.)

Greetings,
                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message